✅️How to do great PR Reviews?
Hi folks, Wanted some tips on how to do good PR reviews? Also how do you make sure you don't hurt someone's ego during PR reviews, especially developers who are senior to you?
(1) Provide a tag on each comment that you leave - whether it's critical, a minor issue or a nit
(2) Leave comments in a tentative language, maybe even as a suggestive question. "Could we consider doing this?"
(3) It is always best to add a reason justifying your suggestions.
(4) When in doubt, ask a question to understand the change before leaving a possibly unjustified comment.
(5) If you're having too many back-and-forths, just get on a call and resolve all of those sync.
A junior doing code review for senior? That’s unheard of. Just be humble in ur review? Like don’t comment for code style or something that’s just ur personal opinion.
See more comments
