Seniors being pain in ass
I work as a SDE1, and have been working on a new project, and I get it the deadlines and all but this senior have been pushing commits on my PR. I get it I'm a noob but they could leave comments or maybe get on call. Even yesterday this dude pushed refactor commits, it's soo irritating as I have to go through his changes and tbh refactoring is fine but he doesn't have to change everything whatever he finds better. Talked to my manager, he mentioned its fine but not everytime. Ps: yeah ik it helps me to leaen but it's damn irritating.
Wow,
If your senior devs aren't providing you meaningful review comments for refactoring but doing those themselves, then they aren't really senior devs. Senior devs should be using code reviews to mentor junior devs.
Do you know why they do it? Is it for some refactoring brownie points? Do you make it difficult for them to provide review comments in time?
No and no. Moreover Im always up for getting reviews, he made few comments on first iteration and I made changes accordingly and refactored as well. Out of nowhere a commit was pushed later on the same day.
That's very odd. Especially that your manager isn't taking it seriously. I would start preparing for the worst and be prepared for interviewing.
This could be a way to position you as someone who requires a PIP.
SaveBugs
Stealth
a year ago
Don't they know how to use Code Review feature available in every git service provider?
CaptainLevi
Stealth
a year ago
Why aren't they just pointing out improvements in your PRs? Bring it up to your engineering manager or project manager if they don't hear the first time
I bought it up, will do it again. Really wanna quit this job now it's too much.
