Peer/PR Reviews methodology
How do PR reviews happen in your company? Are there any guidelines you follow to ensure Swift and meaningful reviews on your contributions? Any input or opinions are welcomed
RashWorld57
Stealth
a year ago
We don't do PRs at all. 🤡
coderx
Student
a year ago
I believe in most places the review system is kinda mess and main reason people don’t value it
Yes I would imagine so, and that's why we're trying to make sure we don't add ourselves to that list. At the moment the main issue we are facing is that PR reviews are not quick enough. A lot of PRs are going stale
Ghumu
Stealth
a year ago
Make small PR.
One working functionality at a time.
If renaming something that will reflect in multiple files don't send it with another logic.
Add Sonar and git leaks check.
In my company the PRs are linked with issues, and yes we are trying to ensure the issues created are not a combination of multiple tasks.
First time hearing of sonar and git leak, will check it out thanks
Ghumu
Stealth
a year ago
Yes, we also have User stories, bugs, technical user stories, spikes etc.
