Am I overreacting? How to handle PR comments
Have this co worker, who kind of leads my current project. He keeps digging into PRs and adding comments even when others from the team approved it.
How do I politely shut down this activity? or do I have to not take offense and just work on the comments
The PR comments mostly seem like, preference in coding style.
I believe a good code should pay attention to the existing coding style of the package or library or team that you are changing to minimize confusion for the next person.I would strive to document this coding style to make it universal. Ie, point them out to the coding style guide that your team is using.Arguing over coding style without setting standard is pointless.
Just ignore the comments and merge if its approved
Is the preferred coding style is documented? If yes, please follow it, else ask him to document and then follow it
Code review is the most $hitty thing to do. Everyone is a hero when they become judge
Telling what? Not to review PRs that are accepted?