Have this co worker, who kind of leads my current project. He keeps digging into PRs and adding comments even when others from the team approved it.
How do I politely shut down this activity? or do I have to not take offense and just work on the comments
The PR comments mostly seem like, preference in coding style.
I believe a good code should pay attention to the existing coding style of the package or library or team that you are changing to minimize confusion for the next person.I would strive to document this coding style to make it universal. Ie, point them out to the coding style guide that your team is using.Arguing over coding style without setting standard is pointless.
Just ignore the comments and merge if its approved
Is the preferred coding style is documented? If yes, please follow it, else ask him to document and then follow it
Code review is the most $hitty thing to do. Everyone is a hero when they become judge
Telling what? Not to review PRs that are accepted?
Just dm him
Better yet, send an email to the team that your team needs to agree on coding style and create a checkstyle or something similar to enforce it at local build time. Document this need and ask this engineer if he can take a stab at it next time he leaves those comments on your code. He gets to create this checkstyle as per his preference and you get the points for driving uniform coding style practices in team. Win win
I work in a place where people don't auto indent code even when using ide's like intellij and mix various coding styles in one method.
It's a horrible thing to do, which shows that people are not showing enough attention to code. I personally can't stand such folks.
I believe in putting your ego down and following the more experienced developers advice. If you think your code style is better please put the reasoning in the pr comment which will speak for itself.
If it's related to code styling/ formating, get a perl script to annoy you instead of him. Harder to get embarrassed by a script running locally
I have an engineer on my team who thinks his way is the only correct way. He unnecessarily optimizes his code(For example, he uses methods with multiple params instead of passing the whole object), and adds an extra layer of validation e...
I work as a SDE1, and have been working on a new project, and I get it the deadlines and all but this senior have been pushing commits on my PR. I get it I'm a noob but they could leave comments or maybe get on call.
Even yesterday this...
My job is to develop applications and dashboards for my clients. My client manager is an enthusiast. He asks for my base code which usually i don't share or pbix files for the dashboards which again I don't share. When I say i don't shar...
There is this new PM who is making my life living hell. Sets up his own timeline without consulting me how much effort it will take me to execute. The requirements are fuzzy and changes while executing. I am having to delete a ton of my ...
PM se pressure Kaun leta hai? Aukaat mein rakho bhai usko
Document the incompetence of PM in public (Slack, emails with key stakeholders), however, do it in professional langu...