Hi folks, Wanted some tips on how to do good PR reviews? Also how do you make sure you don't hurt someone's ego during PR reviews, especially developers who are senior to you?
(1) Provide a tag on each comment that you leave - whether it's critical, a minor issue or a nit
(2) Leave comments in a tentative language, maybe even as a suggestive question. "Could we consider doing this?"
(3) It is always best to add a reason justifying your suggestions.
(4) When in doubt, ask a question to understand the change before leaving a possibly unjustified comment.
(5) If you're having too many back-and-forths, just get on a call and resolve all of those sync.
Great stuff Thanks for sharing it
A junior doing code review for senior? That’s unheard of. Just be humble in ur review? Like don’t comment for code style or something that’s just ur personal opinion.
Not even nits?
What is nits ?
I am moving up the ladder so I need to become a good PR reviewer as well.
How do PR reviews happen in your company? Are there any guidelines you follow to ensure Swift and meaningful reviews on your contributions? Any input or opinions are welcomed
Leadership is clueless and one of the most toxic workplaces where people are bullied and no boundaries are considered .Just a week before the appraisal cycle, the let go of 100+ folks both billed onsite and offsite without even informin...
I recently transitioned from an intern to a FTE in a startup. I'm working on a SaaS product as an APM.
I have been taking up a lot of work, interacting with devs, QA, designers but neither do I feel that my manager notices what all I'm ...
