Have this co worker, who kind of leads my current project. He keeps digging into PRs and adding comments even when others from the team approved it.
How do I politely shut down this activity? or do I have to not take offense and just work on the comments
The PR comments mostly seem like, preference in coding style.
I believe a good code should pay attention to the existing coding style of the package or library or team that you are changing to minimize confusion for the next person.I would strive to document this coding style to make it universal. Ie, point them out to the coding style guide that your team is using.Arguing over coding style without setting standard is pointless.
Just ignore the comments and merge if its approved
Is the preferred coding style is documented? If yes, please follow it, else ask him to document and then follow it
Code review is the most $hitty thing to do. Everyone is a hero when they become judge
Telling what? Not to review PRs that are accepted?
I have an engineer on my team who thinks his way is the only correct way. He unnecessarily optimizes his code(For example, he uses methods with multiple params instead of passing the whole object), and adds an extra layer of validation e...
I work as a SDE1, and have been working on a new project, and I get it the deadlines and all but this senior have been pushing commits on my PR. I get it I'm a noob but they could leave comments or maybe get on call.
Even yesterday this...
Wow, If your senior devs aren't providing you meaningful review comments for refactoring but doing those themsel...
I have joined this new company Individually contribute and work with folks onsite. I report to a manager who have multiple projects There is this guy who is like 3-4 yrs experience but behaves like he is the boss when manager isn't aroun...
